Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sending large STOMP messages as fragmented frames on WebSocketStompClient #31970

Closed
wants to merge 1 commit into from
Closed

Support sending large STOMP messages as fragmented frames on WebSocketStompClient #31970

wants to merge 1 commit into from

Conversation

injae-kim
Copy link
Contributor

Closes gh-29354

Motivation

Modification

  • Add SplittingStompEncoder to split large STOMP messages that exceeds outboundMessageSizeLimit

Result

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 7, 2024
@injae-kim injae-kim force-pushed the send-stomp-messages-fragmented-frames branch from 824d2d3 to 43b272c Compare January 7, 2024 17:00
@injae-kim injae-kim mentioned this pull request Jan 7, 2024
Closed
@rstoyanchev rstoyanchev self-assigned this Jan 9, 2024
@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 9, 2024
@rstoyanchev rstoyanchev added this to the 6.2.0-M1 milestone Jan 9, 2024
rstoyanchev
rstoyanchev reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change looks good. I think it would be good to have dedicated unit tests for SplittingStompEncoder in spring-messaging in addition to the those in spring-websocket.

@injae-kim injae-kim force-pushed the send-stomp-messages-fragmented-frames branch from 43b272c to 05a990e Compare January 14, 2024 12:58
@injae-kim
Copy link
Contributor Author

(Rebase to latest main branch to resolve conflict~!)

@injae-kim injae-kim mentioned this pull request Jan 15, 2024
Closed
@injae-kim
Copy link
Contributor Author

Seems mentioned +1 on #31901 😄

@injae-kim injae-kim requested a review from rstoyanchev January 23, 2024 12:00
rstoyanchev pushed a commit that referenced this pull request Mar 12, 2024
@injae-kim @rstoyanchev
Support splitting STOMP messages in WebSocketStompClient
76d00d7 
See gh-31970
rstoyanchev added a commit that referenced this pull request Mar 12, 2024
@rstoyanchev
Split messages only if configured to do so
73ee86c 
See gh-31970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev Awaiting requested review from rstoyanchev

Assignees

@rstoyanchev rstoyanchev

Labels
in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-M1
Development

Successfully merging this pull request may close these issues.

Support sending large STOMP messages as fragmented frames
3 participants
@injae-kim @rstoyanchev @spring-projects-issues