(docs): Replace @RequestMapping with newer @GetMapping (etc.)
#957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaMaciaszek
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Hello @AlexElin, thanks for submitting the PR. Have added a comment. Please address it.
| @@ -39,16 +39,16 @@ public class Application { | |||
| ---- | |||
| @FeignClient("stores") | |||
| public interface StoreClient { | |||
| @RequestMapping(method = RequestMethod.GET, value = "/stores") | |||
There was a problem hiding this comment.
Please leave this one as @RequestMapping - like this we showcase various possible options.
AlexElin
force-pushed
the
docs_replace_request_mapping
branch
from
43596ee to
8e341cc
Compare
OlgaMaciaszek
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the subject