[Fix] [Travis] Execute 'go vet', use stages, use language conf list, add go 1.12.x, update shellcheck #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tries in matrix.include
|
|
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Mar 18, 2019
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Mar 18, 2019
…tries in matrix.include (spf13#839)
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Mar 18, 2019
|
Closed in favour of #840. |
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Mar 19, 2019
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Mar 19, 2019
…tries in matrix.include (spf13#839)
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Mar 19, 2019
eparis
pushed a commit
that referenced
this pull request
Mar 20, 2019
…ts list... (#840) * update Example in README.md (#769) * specify the color as the required arg (#777) * command: fix typo in docstring of InheritedFlags (#779) * add istio to the list of projects built with Cobra (#786) * remove redundant 'else' (#806) * add mattermost-server as a project built with Cobra (#824) * update README.md (#826) Fix the comment: consistent with others * add uber/prototool as a project built with Cobra (#831) * fix(ci): use go vet, update to Go 1.12, update shellcheck to v0.4.6 (#832) * add go.mod and go.sum (#833) * chore(travis): move 'diff' job to separate stage in Travis (#839) * chore(travis): use language configuration list instead of explicit entries in matrix.include (#839) * chore(travis): update shellcheck-docker to v0.6.0 (#839) * update(README.md): separate projects by commas, instead of using a list * chore: update viper to v1.3.2 and go-md2man to v1.0.10 * fix: convert CRLF to LF when comparing files * use kyoh86/richgo to provide colored test outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several minor enhancements to
.travis.yml:>1.11(i.e.tipand/or1.12).diffofgofmtto a separate stage in Travis, because it is not a test.matrix.include. This is a more natural way to handle the config in Travis.1.12.x.shellcheck-dockertov0.6.0.This PR conflicts with #832. I can either rebase on top of @peter-edge's branch, or let him rebase on top of this. @eparis, wdyt?