Route: Only encode placeholders in type parameter #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tindzk
force-pushed
the
issue/28
branch
2 times, most recently
from
a47a3ee to
8a780ee
Compare
Previously, static path elements were encoded in `Route`'s `HList`. This prevented conditional routes such as the following: ```scala if (isProduction) Root / "api" / "v2.0" else Root ``` Change the implementation such that only placeholders (e.g. `Arg[String]` or `Fragment[Int]`) are encoded in `Route`'s type parameter. Also, simplify the design by using tuples instead of `HList`s. As a consequence, the compile-time and run-time footprint is reduced. **Detailed changes:** - Use tuples instead of `HList`s - Eliminate all type casts - Drop all external dependencies (Shapeless, Cats) - Argument and fragment placeholders are now encoded in `Route`'s type parameter - Change fragment delimiter from `#` to `$` - Route parsing does not fail anymore when additional path elements are specified - Drop `ParamOpt[T]` in favour of `Param[Option[T]]` - Optional route arguments can now be populated with `None` instead of `Option.empty[T]` - Remove all type aliases - Custom `Codec`s can read/emit optional arguments Closes #14. Closes #28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, static path elements were encoded in
Route'sHList.This prevented conditional routes such as the following:
Change the implementation such that only placeholders (e.g.
Arg[String]orFragment[Int]) are encoded inRoute's typeparameter.
Also, simplify the design by using tuples instead of
HLists. As aconsequence, the compile-time and run-time footprint is reduced.
Detailed changes:
HListsRoute'stype parameter
#to$are specified
ParamOpt[T]in favour ofParam[Option[T]]Noneinsteadof
Option.empty[T]Codecs can read/emit optional argumentsCloses #14.
Closes #28.