Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add isort and black new #975

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

VishnuSanal
Copy link
Contributor

Description

This PR supersedes #972

Summary

This PR enables isort and black to run on every PR

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Oct 5, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Oct 5, 2024

CodSpeed Performance Report

Merging #975 will not alter performance

Comparing VishnuSanal:ci/add-isort-and-black-new (c4438cc) with main (3415fcd)

Summary

✅ 116 untouched benchmarks

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 0:42am

@sansyrox
Copy link
Member

sansyrox commented Oct 6, 2024

Love it!

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sansyrox sansyrox merged commit 028f161 into sparckles:main Oct 6, 2024
61 checks passed
@VishnuSanal VishnuSanal deleted the ci/add-isort-and-black-new branch October 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants