-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Interpreter and Testing Refactor #1745
base: master
Are you sure you want to change the base?
Conversation
There is remaining work:
|
Clarification: The inspector component (src/inspector) has been removed some time ago, which is good. It wasn't maintained and stopped working. The component For clarity we should rename it to |
I've always heavily disliked how it makes use of global variables. Is there something we can do about this? |
If only the |
I think other runners could also use break points. It would be a great feature for the stepper too. So in anticipation of that, we could keep the breakpoints feature in |
@martin-henz has indicated that
concurrent
,concurrency
and certain parts ofvm
can be removed. This PR does just that, though I am not 100% certain I have removed the obsolete components entirely.Since nothing else relies on the interpreter, this PR also removes it entirely. I have thus managed to refactor our testing utilities. I don't know if that has changed anything, but for the most part all our tests still pass; some error test cases have different error messages now.
Resolves:
src/vm/svml-machine.ts
#1697