Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSE Machine: Fixed bug in for loops #1734

Merged
merged 5 commits into from
Feb 18, 2025
Merged

CSE Machine: Fixed bug in for loops #1734

merged 5 commits into from
Feb 18, 2025

Conversation

chuckyang123
Copy link
Contributor

@chuckyang123 chuckyang123 commented Feb 10, 2025

Description

changes initialisation in for loops to fit Source specification as per #1727

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How to test

let y=0;
for (let i=(y=y+1);i<=1;i=i+1){
display(i);
}
now runs through a loop and display 1 instead of undefined

Checklist

  • I have tested this code

Sorry, something went wrong.

@alsonleej alsonleej requested a review from s-kybound February 12, 2025 10:07
@martin-henz martin-henz changed the title Fixed bug in for loops CSE Machine: Fixed bug in for loops Feb 17, 2025
chuckyang123 and others added 3 commits February 17, 2025 16:07
@alsonleej
Copy link
Contributor

added fix for Block evaluation too fast #1735

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13370369039

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 81.652%

Totals Coverage Status
Change from base Build 12903670513: -0.002%
Covered Lines: 11472
Relevant Lines: 13661

💛 - Coveralls

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@martin-henz martin-henz merged commit eaa71ce into master Feb 18, 2025
4 checks passed
@martin-henz martin-henz deleted the forloops branch February 18, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants