-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stepper: add the comment to link the specification #1680
Merged
martin-henz
merged 8 commits into
master
from
1679-adding-comments-for-stepperts-for-easier-understanding
Sep 10, 2024
Merged
stepper: add the comment to link the specification #1680
martin-henz
merged 8 commits into
master
from
1679-adding-comments-for-stepperts-for-easier-understanding
Sep 10, 2024
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10793219639Details
💛 - Coveralls |
Loading status checks…
…ier-understanding
martin-henz
requested changes
Apr 16, 2024
RichDom2185
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit: the comments should be either
// line 1
// line 2
or /* ... */
multi-line comments, not /** .... */
documentation comments.
Loading status checks…
…ier-understanding
Loading status checks…
…ier-understanding
Loading status checks…
…ier-understanding
It seems that this PR is not difficult to fix so that it can be merged. @FYL2003 can you take another look please. |
Loading status checks…
…ier-understanding
martin-henz
approved these changes
Sep 10, 2024
Loading status checks…
…ier-understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is uploaded.