Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepper: add the comment to link the specification #1680

Merged

Conversation

FYL2003
Copy link
Contributor

@FYL2003 FYL2003 commented Apr 16, 2024

The change is uploaded.

@FYL2003 FYL2003 requested a review from martin-henz April 16, 2024 01:56
@FYL2003 FYL2003 linked an issue Apr 16, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 10793219639

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 81.552%

Totals Coverage Status
Change from base Build 10792762869: 0.009%
Covered Lines: 10927
Relevant Lines: 13031

💛 - Coveralls

…ier-understanding
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit: the comments should be either

// line 1
// line 2

or /* ... */ multi-line comments, not /** .... */ documentation comments.

…ier-understanding
…ier-understanding
…ier-understanding
@martin-henz
Copy link
Member

It seems that this PR is not difficult to fix so that it can be merged. @FYL2003 can you take another look please.

martin-henz and others added 2 commits July 19, 2024 14:51
…ier-understanding
@martin-henz martin-henz changed the title add the comment to link the specification stepper: add the comment to link the specification Sep 10, 2024
…ier-understanding
@martin-henz martin-henz merged commit d3c1191 into master Sep 10, 2024
4 checks passed
@martin-henz martin-henz deleted the 1679-adding-comments-for-stepperts-for-easier-understanding branch September 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Adding comments for stepper.ts for easier understanding
4 participants