CSE Machine fixes for variadic functions, closures & heap #1645
+6,762
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make closureToJS use CSE machine instead of interpreter - add variadic function array to heap - handle functions from `stream` - added heap move method
Pull Request Test Coverage Report for Build 8608170634Details
💛 - Coveralls |
martin-henz
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Great to see "closure" in this folder instead of using the legacy interpreter implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes many issues related to the new heap addition.
Changes
Closureclass for use in the CSE MachineclosureToJSuse CSE Machine instead of the old interpreterapply_in_underlying_javascriptto correctly display the environment and ensure objects get added to the heap correctlydeclaredNameproperty inClosure, which stores the name of the constant variable the closure is assigned toapply_in_underlying_javascriptto create environment frames with better namesfunctionNamewill now always be in the form ofx => ...environmentproperty to functions returned from callingstreammovemethod inHeapfor use in the frontendStackandIStackto a separate file to avoid circular dependency issues