-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parser to new scm-slang parser #1584
Merged
Merged
+387
−2,931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-henz
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice comments. Great to see the CSE machine in action as a Source Academy runner, including REPL.
Pull Request Test Coverage Report for Build 8372106243Details
💛 - Coveralls |
Loading status checks…
…ation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update completely converts the scm-slang parser used in js-slang to use the newer version.
This improved parser supports:
Most importantly - the parser now uses an intermediate AST representation, which has allowed us to perform above actions such as optimizations and scope repair. Most importantly, it is the first step for conversion between a full LISP AST and the IR AST used, which will greatly help in the future when implementing macro systems for the scheme implementation.
On js-slang's side, continuation representation now accepts a variadic amount of arguments, which will, in the future, allow us to implement scheme procedures that produce more than 1 value.
Resolves #1408.