Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NodeJS to version 20 #1513

Merged
merged 8 commits into from
Jan 20, 2024
Merged

Bump NodeJS to version 20 #1513

merged 8 commits into from
Jan 20, 2024

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Jan 16, 2024

Node 16 is EOL and Node 18 has build problems, but Node 20 seems to work fine and all tests pass locally on my MacBook.

TODOs:

  • Update CI
  • Update README

Sorry, something went wrong.

Also bumps the version of `node-gyp` transitive dependency to address a
security vulnerability.
@RichDom2185 RichDom2185 requested a review from sayomaki January 16, 2024 04:09
@RichDom2185 RichDom2185 self-assigned this Jan 16, 2024
@RichDom2185 RichDom2185 changed the title Bump to NodeJS version 20 Bump NodeJS to version 20 Jan 16, 2024
@RichDom2185 RichDom2185 marked this pull request as draft January 16, 2024 04:12
Bumps dependency versions, as well as remove manual caching.
@coveralls
Copy link

coveralls commented Jan 16, 2024

Pull Request Test Coverage Report for Build 7593133001

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 82.937%

Totals Coverage Status
Change from base Build 6702227868: 0.08%
Covered Lines: 10893
Relevant Lines: 12706

💛 - Coveralls

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's have this merged and ready ASAP so that it becomes easier to setup with the same node version as the frontend.

@sayomaki sayomaki marked this pull request as ready for review January 19, 2024 06:43
* Update Node version
* Remove duplicate header
* Change H1s to H2s for better hierarchy
* Remove soft breaks
* Add syntax highlighting for commands
* Fix license line break
@RichDom2185
Copy link
Member Author

Looks good! Let's have this merged and ready ASAP so that it becomes easier to setup with the same node version as the frontend.

Great, thanks! I've updated (and reformatted) the README as well, will merge after the CI passes.

@RichDom2185 RichDom2185 enabled auto-merge (squash) January 20, 2024 08:05
@RichDom2185 RichDom2185 merged commit 264f05c into master Jan 20, 2024
@RichDom2185 RichDom2185 deleted the node-20 branch January 20, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants