Use UNKNOWN_LOCATION if node location does not exist #1378
Merged
+136
−106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is necessary for multiple file programs to work correctly in the frontend. This is because the AST nodes which are added by the preprocessor do not have a corresponding location (due to not being parsed from code in the first place). One of the instances of
.loc!
is being called (no idea which because it's almost impossible to trace without proper error handling), resulting in the evaluation of multiple-file programs dying.We really should ban the use of the non-null assertion operator (
!
). Its only purpose is to let lazy programmers write code that bypass the type checker.Part of source-academy/frontend#2176.