Skip to content

Game: Rename Story Simulator references to Game Simulator #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

lhw-1
Copy link
Collaborator

@lhw-1 lhw-1 commented Feb 23, 2024

Description

Resolves #2679.

Renames all the direct references to Story Simulator to Game Simulator within the codebase, to be consistent with changes made in #2673. While the Game Developer Guide has been updated, the Storywriter Guide has not been updated with these changes; the appropriate changes will be made once the Game Simulator refactor is complete (as this is not a breaking / major change).

This can be considered the first part of a planned refactor / update for the Game Simulator. Files containing the term SS, though indirectly referring to the Story Simulator, have not yet been renamed as they are planned to be renamed during the next round of refactoring anyway.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Feb 23, 2024

Pull Request Test Coverage Report for Build 8019832719

Details

  • -18 of 18 (0.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 36.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/gameSimulator/subcomponents/GameSimulatorAssetSelection.tsx 0 1 0.0%
src/features/gameSimulator/scenes/ObjectPlacement/ObjectPlacement.ts 0 2 0.0%
src/pages/academy/gameSimulator/subcomponents/GameSimulatorGame.ts 0 2 0.0%
src/features/gameSimulator/scenes/mainMenu/MainMenu.ts 0 6 0.0%
src/pages/academy/gameSimulator/GameSimulator.tsx 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/Academy.tsx 1 0.0%
Totals Coverage Status
Change from base Build 8019400013: 0.0%
Covered Lines: 5730
Relevant Lines: 14577

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185 RichDom2185 merged commit e842e48 into source-academy:master Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename StorySimulator to GameSimulator
4 participants