Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSF address in license text #3934

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

sandrobonazzola
Copy link
Contributor

While packaging for Fedora, rpmlint detected incorrect FSF address in a few files. Updating with most recent version of GPLv2 text from https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

While packaging for Fedora, rpmlint detected incorrect FSF address in a
few files. Updating with most recent version of GPLv2 text from
<https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt>

Signed-off-by: Sandro Bonazzola <[email protected]>
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3934
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

/packit rebuild-failed

1 similar comment
@arif-ali
Copy link
Member

/packit rebuild-failed

@arif-ali arif-ali added the Status/Needs Review This issue still needs a review from project members label Feb 18, 2025
@arif-ali arif-ali added the Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer label Feb 18, 2025
@bmr-cymru
Copy link
Member

bmr-cymru commented Feb 18, 2025

There's another partial copy with the old FSF address at debian/copyright, probably worth updating too?

...
Files: debian/tests/simple.sh
Copyright: 2020 Eric Desrochers <[email protected]>
 (C) 2020-2025 Canonical Ltd.
License: GPL-2

License: GPL-2
 This program is free software; you can redistribute it and/or
 modify it under the terms of the GNU General Public License
 as published by the Free Software Foundation; version 2.
 .
 This application is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 General Public License for more details.
 .
 You should have received a copy of the GNU General Public License
 along with this program; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301,
 USA.

License: GPL-2+
 This program is free software; you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation; either version 2 of the License, or (at
 your option) any later version.
 .
 This program is distributed in the hope that it will be useful, but
 WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 General Public License for more details.
 .
 You should have received a copy of the GNU General Public License
 along with this program; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301,
 USA.
 .
 On Debian systems, the complete text of the GNU General Public
 License, version 2, can be found in /usr/share/common-licenses/GPL-2.

@arif-ali
Copy link
Member

hmm, bizarre the debian lintian tool didn't pick that one up. I know while packaging avocado it picked up issues with addresses and debian/copyright and such 🤔

@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Feb 18, 2025
@TurboTurtle TurboTurtle merged commit 34a3179 into sosreport:main Feb 18, 2025
42 checks passed
@sandrobonazzola sandrobonazzola deleted the fix_fsf_address branch February 19, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants