Add migration version to migrations #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To eliminate this deprecation warning:
DEPRECATION WARNING: Directly inheriting from ActiveRecord::Migration is deprecated. Please specify the Rails release the migration was written for
jordan-brough
force-pushed
the
specify-migration-version
branch
from
0079fe5 to
7ca771d
Compare
|
As this extension still needs to support older versions of Solidus on Rails 4.2, I don't think we can do this. |
jordan-brough
force-pushed
the
specify-migration-version
branch
from
3311388 to
dc1a5f3
Compare
Since this gem is trying to stay compatible with Rails 4.2+.
jordan-brough
force-pushed
the
specify-migration-version
branch
from
dc1a5f3 to
80c24b8
Compare
|
I would strongly prefer not to add a new class method to Until Rails begins mandating pinning migration versions, or this extension exclusively supports Rails 5+, I believe the best course of action is to leave the migrations as-is. |
|
In rails 5.1 this is no longer just a warning.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To eliminate this deprecation warning: