Refactor Spree::Auth::Engine #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are used to determine if an engine/gem is available, by checking all currently-registered Rails::Engine subclasses. This code had gone through several iterations, and was now overly complex, redundant, and difficult to read.
Simplifies config.to_prepare call for Spree::Auth::Engine. Previous version made use of `&method`, and was confusing to new viewers of this file. The contents of Spree::Auth::Engine.activate have been pulled out into the new methods `prepare_backend` and `prepare_frontend`. These add assets, load decorator classes, and set up redirects as necessary, depending on whether or not the related Solidus gem is available.
Since we're invoking these methods in the same context that they're defined, we don't need to prefix the calls with an identifier.
A small fix, but brings code more in-line with modern Ruby style recommendations.
|
This looks good to me. Thanks @stewart. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of small refactorings to
Spree::Auth::Engine. The code in here was not amazing, I've attempted to simplify it where possible.