check_authorization first in CheckoutController #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common for developers to use $RAILS_ROOT/vendor to install per-project gems via bundler. No need to have that be part git.
It is possible that for no current_order to be defined, and thus cause an exception to be raised here.
When we changed this to a prepend_before_filter we failed to recognize that we needed to change the sequence of the filter definitions so that check_authorization would fire before check_registration.
|
👍, thanks again Brian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we changed this to a prepend_before_filter we failed to recognize
that we needed to change the sequence of the filter definitions so that
check_authorization would fire before check_registration.
Also:
current_orderwhich may benilvendorto.gitignore