Logout with DELETE verb by default #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/fix-default-delete-method
branch
from
10c6fc8 to
7bf7d62
Compare
spaghetticode
approved these changes
Jul 3, 2019
jacobherrington
approved these changes
Jul 8, 2019
|
I'm not sure about backward compatibility here and I'm not super sure what to do, leaving WIP for now, please do not merge yet. |
This changed in Devise and we did not reflect this change over here. This commit will change how sign out works, so if users are manually using the GET verb to sign out users they will have to change it manually.
At the moment we are only supporting usign GET but the frontend routes allow customizing it using Devise.sign_out_via preference.
following value of Devise.sign_out_via preference
kennyadsl
force-pushed
the
kennyadsl/fix-default-delete-method
branch
from
7bf7d62 to
1ecfbca
Compare
|
We discussed this in the core team meeting and we are fine merging this as is and releasing a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago Devise changed the default HTTP verb used to sign out from
GETtoDELETE.This PR re-aligns this preference default with what is shipped with Devise. It also improves the code to be more dynamic since we were not really supporting changing that preference.
🚨Can be breaking 🚨
Stores that rely on signing out with
GETverb will need to change theDevise.sign_out_viaconfiguration atconfig/initializers/devise.rb: