Test that we are acting as paranoid not it's behaviour #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `acts_as_paranoid` to enable soft delete. The current spec for `destroy` tests the behaviour of the `acts_as_paranoid` gem. Also it tests behaviour that is not possible with latest version of Solidus (86d0e6281cf04a856766f7da1506d8007164f0ae) any more. We can't destroy users that have orders assigned to them. This is sufficienlty tested in Solidus core and must not be tested here again. Therefore I think it is safe to remove this spec and replace it with a basic duck typing test to ensure we are still using `acts_as_paranoid`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
acts_as_paranoidto enable soft delete. The current specfor
destroytests the behaviour of theacts_as_paranoidgem.Also it tests behaviour that is not possible with latest version of
Solidus (86d0e6281cf04a856766f7da1506d8007164f0ae) any more.
We can't destroy users that have orders assigned to them.
This is sufficienlty tested in Solidus core and must not be tested here again.
Therefore I think it is safe to remove this spec and replace it with a basic
duck typing test to ensure we are still using
acts_as_paranoid.