Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthenticationHelpers reference routes that may not exist #59

Closed
bbuchalter opened this issue Jun 14, 2016 · 0 comments
Closed

AuthenticationHelpers reference routes that may not exist #59

bbuchalter opened this issue Jun 14, 2016 · 0 comments

Comments

@bbuchalter
Copy link
Contributor

When loading the engine, Spree:: AuthenticationHelpers is unconditionally included with ApplicationController regardless of the presence of the solidus_frontend gem. However, Spree:: AuthenticationHelpers references named routes which are only defined if the solidus_frontend gem is used.
stewart added a commit that referenced this issue Jun 22, 2016
@stewart
Add guard for frontend-based AuthenticationHelpers
39160b8 
These Spree::AuthenticationHelpers methods should only be available for
apps that have `solidus_frontend` available, as they are simply proxies
for route helpers provided by that gem.

Closes #59.
@stewart stewart mentioned this issue Jun 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbuchalter