Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue build if fetching latest version fails #404

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

RaduPetreTarean
Copy link
Contributor

This allows the build to pass if the server serving the latest global version is not available

This allows the build to pass if the server serving the latest global version is not available
@RaduPetreTarean RaduPetreTarean requested a review from a team as a code owner January 28, 2025 15:14
Copy link

@malinbranduse malinbranduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, only thing missing would be a unit test to confirm this edge case. might be helpful down the line to remember why this change was added and what's the expected behaviour.

malinbranduse

This comment was marked as off-topic.

@RaduPetreTarean RaduPetreTarean force-pushed the fix/continue-build-without-latest-version branch 2 times, most recently from f919493 to e819258 Compare February 3, 2025 16:01
@RaduPetreTarean RaduPetreTarean force-pushed the fix/continue-build-without-latest-version branch from e819258 to a15a094 Compare February 4, 2025 10:48
@RaduPetreTarean RaduPetreTarean merged commit 4cb0b38 into main Feb 4, 2025
13 checks passed
@RaduPetreTarean RaduPetreTarean deleted the fix/continue-build-without-latest-version branch February 4, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants