Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use reusable workflows for fmt and security_audit & fix CI failure #93

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

taiki-e
Copy link
Collaborator

@taiki-e taiki-e commented Jan 19, 2025

See smol-rs/.github#1 for details about reusable workflows.
See the second commit for CI failure.

```
error: spawned process is never `wait()`ed on
  --> src/reaper/signal.rs:66:25
   |
66 |                         zombies.swap_remove(i);
   |                         ^^^^^^^^^^^^^^^^^^^^^^- help: try: `.wait()`
   |
   = note: not doing so might leave behind zombie processes
   = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes
   = note: `-D clippy::zombie-processes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::zombie_processes)]`
```
@taiki-e taiki-e changed the title ci: Use reusable workflows for fmt and security_audit ci: Use reusable workflows for fmt and security_audit & fix CI failure Jan 19, 2025
@taiki-e taiki-e merged commit 83857bb into master Jan 23, 2025
15 checks passed
@taiki-e taiki-e deleted the taiki-e/ci branch January 23, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant