Add site to powerset during merge #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot I hadn't cut over all the test data, which i'll do seperately to spare your eyes: #76 |
mikix
approved these changes
Apr 19, 2023
Comment on lines
-149
to
+183
| site = s3_key_array[0] | ||
| site = s3_key_array[3] |
There was a problem hiding this comment.
Was this intentional - it feels different than the rest.
There was a problem hiding this comment.
it was - this was accidentally pulling in the bucket name rather than the site in question.
There was a problem hiding this comment.
Were we missing a test that would have caught that? Should we add one that would now?
There was a problem hiding this comment.
Probably - this is sort of related to #71 but i could do some of that as part of this.
There was a problem hiding this comment.
well that was a good call - there were some logical errors in the S3 mock that I wasn't catching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes: