Skip to content

Add parameters to allow additional color orderings #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

david-sawatzke
Copy link
Collaborator

Fixes #7

I've ignored RGBW for now, as I haven't heard of any pixel order variations of them.

If I'm not completely mistaken, this doesn't introduce any breaking API changes

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/prerendered.rs:38

  • [nitpick] Consider using a consistent generic parameter name for pixel ordering throughout the code (e.g., use 'PO' in place of 'PIXELORDER' in the struct definition) to improve readability and reduce potential confusion.
pub struct Ws2812<'a, SPI, DEVICE = devices::Ws2812, PIXELORDER = pixel_order::GRB> {

src/lib.rs:77

  • [nitpick] Consider aligning the generic parameter naming with the implementations (e.g., using 'PO' consistently instead of 'PIXELORDER' in the struct definition) for better clarity.
pub struct Ws2812<SPI, DEVICE = devices::Ws2812, PIXELORDER = pixel_order::GRB> {

Should be backwards compatible

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGB order vs. GRB order
1 participant