-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to configure rekor server. #391
Merged
laurentsimon
merged 3 commits into
slsa-framework:main
from
naveensrinivasan:naveen/feat/configure-rekor
Jun 27, 2022
Merged
Option to configure rekor server. #391
laurentsimon
merged 3 commits into
slsa-framework:main
from
naveensrinivasan:naveen/feat/configure-rekor
Jun 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provided an option to configure the rekor server. - Fixes slsa-framework#372 Signed-off-by: naveensrinivasan <[email protected]>
5825482
to
c5cc9ed
Compare
ianlewis
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think we might want to update the generic generator as well before closing #372 though. |
c177021
to
413cdfe
Compare
ianlewis
reviewed
Jun 24, 2022
413cdfe
to
3c0b783
Compare
laurentsimon
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
3 tasks
laurentsimon
added a commit
to laurentsimon/slsa-github-generator
that referenced
this pull request
Jun 29, 2022
* Option to configure rekor server. - Provided an option to configure the rekor server. - Fixes slsa-framework#372 Signed-off-by: naveensrinivasan <[email protected]> * mend Co-authored-by: laurentsimon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: naveensrinivasan [email protected]