-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP Asic Memory Integration Flow Stratus Compliant #196
Conversation
…er construction to support ASIC and FPGA
…er construction to support ASIC and FPGA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few questions and minor things to fix
.gitignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add these to the gitignore? To avoid accidentally pushing technology files? why the flists also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the asic mem and wrappers, yes. They are link to folders outside ESP repository.
For the techmap, it is now automatically generated when launching esp-config. This is to facilitate portability from one asic technology to another by just relink tech dependent files and regenerate techmap_*.flist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer to have these in .gitignores further down in the hierarchy?
Can we create new .gitignores in:
utils/flist/
rtl/techmap/asic/
rtl/sim/gf12/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the idea of having many .gitignores in the folder hierarchy. It would be a nightmare to find what we are ignoring in the future.
@@ -1,5 +1,3 @@ | |||
# Copyright (c) 2011-2023 Columbia University, System Level Design Group | |||
# SPDX-License-Identifier: Apache-2.0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add back the copyright?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't removed it. I will add them back anyways. There was a command to do/update them automatically, right!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KL has a script that does all the files, but I think since you have just 3, you can do it manually
@@ -1,4 +1,4 @@ | |||
-- Copyright (c) 2011-2023 Columbia University, System Level Design Group | |||
-- Copyright (c) 2011-2022 Columbia University, System Level Design Group | |||
-- SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix copyright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't changed this file
rtl/techmap/asic/pads_gf12.vhd
Outdated
@@ -1,4 +1,4 @@ | |||
-- Copyright (c) 2011-2023 Columbia University, System Level Design Group | |||
-- Copyright (c) 2011-2022 Columbia University, System Level Design Group | |||
-- SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix copyright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't changed this file
-currently only supports accelerator design with Stratus HLS Co-authored-by: Joseph Zuckerman <[email protected]>
-currently only supports accelerator design with Stratus HLS Co-authored-by: Joseph Zuckerman <[email protected]>
No description provided.