Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update depends_on to be a list #218

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

nmathew98
Copy link
Collaborator

docker/compose#9957

also depends_on is ignored in swarm mode

Copy link

Deploying skulpture-xyz with  Cloudflare Pages  Cloudflare Pages

Latest commit: 276fee3
Status: ✅  Deploy successful!
Preview URL: https://1a353e39.skulpture-xyz.pages.dev
Branch Preview URL: https://chore-depends-on-list.skulpture-xyz.pages.dev

View logs

@nmathew98 nmathew98 enabled auto-merge (squash) November 17, 2024 05:46
Copy link

Title

chore: update depends_on to be a list


User description

docker/compose#9957

also depends_on is ignored in swarm mode


PR Type

enhancement


Description

  • Updated the depends_on section in the Docker Compose file to use a list format, simplifying the configuration.
  • Removed the condition and restart options from the depends_on entries, which are not supported in the list format.

Changes walkthrough 📝

Relevant files
Enhancement
docker-compose.yml
Update `depends_on` to list format in Docker Compose         

api/docker-compose.yml

  • Updated depends_on to use a list format.
  • Removed conditions and restart options from depends_on.
  • +2/-6     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🏅 Score: 85
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change
    The depends_on configuration has been changed to a list format, which may affect service startup order. Ensure that this change aligns with the intended service dependencies.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Verify that all services in depends_on are defined to prevent potential deployment issues

    Ensure that the services listed under depends_on are properly defined in the Docker
    Compose file to avoid runtime errors.

    api/docker-compose.yml [35-36]

    +- landing-api-prod
    +- landing-api-dev
     
    -
    Suggestion importance[1-10]: 3

    Why: The suggestion highlights a potential issue with service dependencies, but the services 'landing-api-prod' and 'landing-api-dev' are already defined later in the file. Thus, while relevant, the impact is minimal.

    3

    Copy link

    🍹 preview on landing/skulpture/landing/prod

    Pulumi report
    Previewing update (prod)
    
    View Live: https://app.pulumi.com/skulpture/landing/prod/previews/c370c467-5da1-4e5b-8a05-884727cf9f50
    
    @ Previewing update....
    Downloading plugin gcp-7.38.0: starting
    Downloading plugin cloudflare-5.36.0: starting
    Downloading plugin cloudflare-5.36.0: done
    Downloading plugin gcp-7.38.0: done
    Installing plugin cloudflare-5.36.0: starting
    Installing plugin gcp-7.38.0: starting
    @ Previewing update....
    Installing plugin cloudflare-5.36.0: done
    @ Previewing update....
    Installing plugin gcp-7.38.0: done
    
    @ Previewing update..........................................................................
    pulumi:pulumi:Stack landing-prod running 
    @ Previewing update....
    pulumi:pulumi:Stack landing-prod  
    Resources:
    6 unchanged
    
    

    @nmathew98 nmathew98 merged commit 1271bc6 into dev Nov 17, 2024
    5 checks passed
    @nmathew98 nmathew98 deleted the chore/depends-on-list branch November 17, 2024 05:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant