Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] differential/incremental testing of estimators does not work #128

Closed
fkiraly opened this issue Oct 10, 2023 · 0 comments · Fixed by #142
Closed

[BUG] differential/incremental testing of estimators does not work #128

fkiraly opened this issue Oct 10, 2023 · 0 comments · Fixed by #142
Labels
bug maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Oct 10, 2023

It seems the incremental testing does not properly work in skpro, unlike in sktime.

I don't understand why it doesn't. This leads to test times of 7min instead of 2min for individual workflow elements.

Failed attempts to fix:
#127
@fkiraly fkiraly added bug maintenance Continuous integration, unit testing & package distribution labels Oct 10, 2023
@fkiraly fkiraly mentioned this issue Oct 28, 2023
Closed
@fkiraly fkiraly changed the title [BUG] incremental testing does not work [BUG] differential/incremental testing of estimators does not work Oct 28, 2023
@fkiraly fkiraly mentioned this issue Oct 28, 2023
Merged
fkiraly added a commit that referenced this issue Oct 28, 2023
@fkiraly
[BUG] fix test fixture generation logic (#142)
3af3536 
This PR fixes the test fixture generation logic, and fixes
#128.

The problem was that some `TestAll...` classes were inheriting from
`skbase` `FixtureGenerator` and not from the `skpro` fixture generator
`FixtureGenerator` (from `test_all-estimators`) which overrides
`_all_objects` to test only incrementally, or objects with available
dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] fix test fixture generation logic sktime/skpro
1 participant
@fkiraly