Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sub modules #78

Merged
merged 22 commits into from
Dec 7, 2022
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test raises msg based on refactor
  • Loading branch information
RNKuhns committed Dec 1, 2022
commit 3834f9593028a014cab804d8d68cdb187675a3d8
5 changes: 3 additions & 2 deletions skbase/tests/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
# TODO: Update with import of skbase clone function once implemented
from sklearn.base import clone

from skbase import BaseObject
from skbase.base import BaseObject

# TODO: Determine if we need to add sklearn style test of
# test_set_params_passes_all_parameters
Expand Down Expand Up @@ -552,9 +552,10 @@ def test_components_raises_error_base_class_is_not_class(
):
composite._components(7)

msg = "base_class must be a class, but found <class 'skbase.base._base.BaseObject'>"
with pytest.raises(
TypeError,
match="base_class must be a class, but found <class 'skbase._base.BaseObject'>",
match=msg,
):
composite._components(fixture_object())

Expand Down