Use "node:fs" instead of "fs" #11
Closed
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boenrobot
force-pushed
the
runtimeCompat
branch
3 times, most recently
from
d5df099 to
ce9a5a2
Compare
… feature. Dev dependencies are also bumped to the newest ones that can run on said minimal nodejs versions and do not require further changes to the code or tests. Also added Windows to the CI tests and updated `actions/setup-node` to `v4`. Excluded Node 14 from MacOS, as those binaries are not available anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And bump the minimum Nodejs version to the versions that support this feature.
Dev dependencies are also bumped to the newest ones that can run on said minimal nodejs versions and do not require further changes to the code or tests.
Also added Windows to the CI tests and updated
actions/setup-nodetov4. Excluded Node 14 from MacOS, as those binaries are not available anymore.This improves compatibility with runtimes other than nodejs (
workerdin particular is known to only provide node compatibility layer for "node:" prefixed modules) at the cost of leaving behind older nodejs versions.