Run TypeScript on the types

[sindresorhus]

tsd only validates the types, it doesn't compile the code, so running TS too is helpful (and would have caught 3bdab60).

[sindresorhus]

Not sure why this affects XO.

[ehmicky]

I was about to open a PR doing exactly this! :)
It is unfortunate that tsd did not catch the typing bugs from 9.0.0. I was thinking of opening an issue on tsd, since ideally those should have been caught by tsd.

The change in xo behavior is probably due to the addition of tsconfig.json.

Maybe this is related to #1040? Let's see if the problem persists after merging #1043.

[sindresorhus]

I was thinking of opening an issue on tsd, since ideally those should have been caught by tsd.

Yeah, would be nice if tsd could run TS too.

[sindresorhus]

Maybe this is related to #1040? Let's see if the problem persists after merging #1043.

Still failing on the same.

[ehmicky]

Looking into it now. 👀

[ehmicky]

The problem was that tsconfig.json adds strict: true (which is good).

One of the type tests needed to be tweaked to avoid an implicit conversion to any, which cannot be avoided due to how instanceof Error narrowing works in TypeScript.

[ehmicky]

The default value of moduleDetection is auto, which uses the package.json type field when module is nodenext. Since we use type: 'module' in package.json, it seems like we could remove the moduleDetection: "force" line? tsc seems to work without it.