Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selections API endpoints to support DVT middleware #7016

Open
wants to merge 13 commits into
base: unstable
Choose a base branch
from

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Feb 20, 2025

Issue Addressed

Proposed Changes

  • Add beacon_committee_selections endpoint
  • Test beacon committee aggregator
  • Add sync_committee_selections endpoint
  • Test sync committee aggregator

Additional Info

Thank you @michaelsproul and @macladson for the help and guidance

@chong-he chong-he added work-in-progress PR is a work-in-progress skip-ci Don't run the `test-suite` dvt Distributed validator technology e.g. SSV, Obol and removed skip-ci Don't run the `test-suite` labels Feb 20, 2025
@chong-he chong-he mentioned this pull request Feb 27, 2025
pub async fn post_validator_beacon_committee_selections(
&self,
selections: &[BeaconCommitteeSelection],
) -> Result<GenericResponse<Vec<SelectionProof>>, Error> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is saying that we expect a Vec<SelectionProof> as the response. A SelectionProof is just a standalone signature. But the middleware will actually return a Vec of objects like this:

{
  "data": [
    {
      "validator_index": "1",
      "slot": "1",
      "selection_proof": "0x1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505cc411d61252fb6cb3fa0017b679f8bb2305b26a285fa2737f175668d0dff91cc1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505"
    }
  ]
}

These objects are BeaconCommitteeSelections, so we need to change the type here to Vec<BeaconCommitteeSelection>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dvt Distributed validator technology e.g. SSV, Obol work-in-progress PR is a work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants