Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Redb implementation and add CI checks #6856

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Fix Redb implementation and add CI checks #6856

merged 6 commits into from
Jan 29, 2025

Conversation

eserilev
Copy link
Collaborator

Ensure Redb compiles and ensure we check for Redb compilation errors during CI

@eserilev eserilev added bug Something isn't working database ready-for-review The code is ready for review v7.0.0-beta.0 New release c. Q1 2025 labels Jan 24, 2025
michaelsproul
michaelsproul requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the whole, just a few minor suggestions

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 28, 2025
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 29, 2025
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 29, 2025
mergify bot added a commit that referenced this pull request Jan 29, 2025
@mergify
Merge of #6856
c25483e
@mergify mergify bot mentioned this pull request Jan 29, 2025
Closed
6 tasks
@mergify mergify bot merged commit 6973184 into sigp:unstable Jan 29, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
bug Something isn't working database ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eserilev @michaelsproul