Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MetaData V3 support to node/identity API #6827

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add MetaData V3 support to node/identity API #6827

merged 1 commit into from
Jan 22, 2025

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Addresses #6348 - add custody_group_count to node/identity response, if Fulu/PeerDA fork is scheduled, otherwise maintain the same behaviour (MetaDataV2 response).

@jimmygchen jimmygchen added HTTP-API das Data Availability Sampling labels Jan 21, 2025
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Jan 21, 2025
jimmygchen added a commit that referenced this pull request Jan 21, 2025
@jimmygchen
Add metadata v3 support to node/identity api (#6827)
6d1bba7 
Squashed commit of the following:

commit d0943ab
Author: Jimmy Chen <[email protected]>
Date:   Tue Jan 21 16:26:54 2025 +1100

    Add metadata v3 support to `node/identity` api.
@jimmygchen jimmygchen mentioned this pull request Jan 21, 2025
Draft
michaelsproul
michaelsproul approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this probably needs a corresponding PR on beacon-apis?

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 22, 2025
@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jan 22, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 2b6ec96

mergify bot added a commit that referenced this pull request Jan 22, 2025
@mergify
Merge of #6827
88bb14c
This was referenced Jan 22, 2025
Closed
Merged
@mergify mergify bot merged commit 2b6ec96 into sigp:unstable Jan 22, 2025
30 checks passed
@jimmygchen
Copy link
Member Author

LGTM, this probably needs a corresponding PR on beacon-apis?

Thanks, I'll work on one this week!

@jimmygchen jimmygchen mentioned this pull request Jan 22, 2025
Closed
dapplion
dapplion reviewed Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion left review comments

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
das Data Availability Sampling HTTP-API ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmygchen @michaelsproul @dapplion