-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builder header timeout flag #5857
Add builder header timeout flag #5857
Conversation
Do we want to force minimum and maximum values for this flag? I don't see why anyone would want this set to less than one second, or to more than 2-3 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to force minimum and maximum values for this flag? I don't see why anyone would want this set to less than one second, or to more than 2-3 seconds
If you set a very low value you will prioritize local building, which you can do today already.
If you set a very high value you will never consider local building and potentially cause liveness issues if builders misbehave. In extreme cases the failover should kick in switching to local building if the failures are common.
I have a soft opinion towards not specifying neither a minimum nor a maximum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I don't have anything else to add!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo capitalisation fix
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at fbc230e |
Issue Addressed
#4709
Proposed Changes
Add a new flag
builder-header-timeout
which allows for configuring timeouts for the get builder header api call. Ive added a max limit of 3 seconds to the timeout to prevent potential liveness issues.