Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add guide to MEV logs #3611

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Add guide to MEV logs #3611

wants to merge 2 commits into from

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Sep 27, 2022 •
edited
Loading

Proposed Changes

Add some docs on checking the builder configuration, which is a frequently asked question on Discord.

Additional Info

My text editor also insisted on stripping some trailing newlines, but can put 'em back if we want

@michaelsproul michaelsproul added ready-for-review The code is ready for review docs Documentation low-hanging-fruit Easy to resolve, get it before someone else does! labels Sep 27, 2022
realbigsean
realbigsean reviewed Sep 27, 2022
View reviewed changes
@realbigsean realbigsean added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 27, 2022
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 27, 2022
realbigsean
realbigsean approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks Michael, this was definitely I was hoping to eventually add

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 28, 2022
@realbigsean
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 28, 2022
@michaelsproul
Add guide to MEV logs (#3611)
abcebf2 
## Proposed Changes

Add some docs on checking the builder configuration, which is a frequently asked question on Discord.

## Additional Info

My text editor also insisted on stripping some trailing newlines, but can put 'em back if we want
@bors
Copy link

bors bot commented Sep 28, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Add guide to MEV logs [Merged by Bors] - Add guide to MEV logs Sep 28, 2022
@bors bors bot closed this Sep 28, 2022
@michaelsproul michaelsproul deleted the builder-docs branch September 28, 2022 20:58
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@michaelsproul @Woodpile37
Add guide to MEV logs (sigp#3611)
21c3317 
## Proposed Changes

Add some docs on checking the builder configuration, which is a frequently asked question on Discord.

## Additional Info

My text editor also insisted on stripping some trailing newlines, but can put 'em back if we want
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrabino1 mrabino1 mrabino1 left review comments

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
docs Documentation low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelsproul @realbigsean @mrabino1