Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix ganache test endpoint for ipv6 machines #3563

Closed
wants to merge 1 commit into from

Conversation

alex88
Copy link
Contributor

@alex88 alex88 commented Sep 11, 2022

Issue Addressed

#3562

Proposed Changes

Change the fork endpoint from localhost to 127.0.0.1 to match the ganache default listening host.
This way it doesn't try (and fail) to connect to ::1 on IPV6 machines.

Additional Info

First PR

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2022

CLA assistant check
All committers have signed the CLA.

@alex88 alex88 force-pushed the ganache-test-endpoint-fix branch from 4496470 to 34e80b6 Compare September 11, 2022 01:00
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks, nice fix!

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Sep 12, 2022
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 13, 2022
## Issue Addressed

#3562

## Proposed Changes

Change the fork endpoint from `localhost` to `127.0.0.1` to match the ganache default listening host.
This way it doesn't try (and fail) to connect to `::1` on IPV6 machines.

## Additional Info

First PR
@bors
Copy link

bors bot commented Sep 13, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 13, 2022
## Issue Addressed

#3562

## Proposed Changes

Change the fork endpoint from `localhost` to `127.0.0.1` to match the ganache default listening host.
This way it doesn't try (and fail) to connect to `::1` on IPV6 machines.

## Additional Info

First PR
@bors
Copy link

bors bot commented Sep 13, 2022

Build failed:

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 13, 2022
## Issue Addressed

#3562

## Proposed Changes

Change the fork endpoint from `localhost` to `127.0.0.1` to match the ganache default listening host.
This way it doesn't try (and fail) to connect to `::1` on IPV6 machines.

## Additional Info

First PR
@bors bors bot changed the title Fix ganache test endpoint for ipv6 machines [Merged by Bors] - Fix ganache test endpoint for ipv6 machines Sep 13, 2022
@bors bors bot closed this Sep 13, 2022
@alex88 alex88 deleted the ganache-test-endpoint-fix branch September 25, 2022 00:28
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

sigp#3562

## Proposed Changes

Change the fork endpoint from `localhost` to `127.0.0.1` to match the ganache default listening host.
This way it doesn't try (and fail) to connect to `::1` on IPV6 machines.

## Additional Info

First PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants