[Merged by Bors] - Add timeout for --checkpoint-sync-url #3521
Conversation
There was a problem hiding this comment.
Awesome, thank you!
I've confirmed that this works and outputs a TimedOut error when requesting a checkpoint from a server that times out
Aug 31 01:02:36.294 INFO Starting checkpoint sync remote_url: http://240.0.0.0:8000/, service: beacon
Aug 31 01:03:36.300 CRIT Failed to start beacon node reason: Error fetching finalized block from remote: Reqwest(reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Ipv4(240.0.0.0)), port: Some(8000), path: "/eth/v2/beacon/blocks/finalized", query: None, fragment: None }, source: TimedOut })
There's a code freeze in effect at the moment while we release v3.1.0, so we'll merge your pull request after that release has shipped. Until then I'll mark this PR as approved but blocked.
michaelsproul
added
blocked
ready-for-merge
|
bors r+ |
## Issue Addressed [Have --checkpoint-sync-url timeout](#3478) ## Proposed Changes I added a parameter for `get_bytes_opt_accept_header<U: IntoUrl>` which accept a timeout duration, and modified the body of `get_beacon_blocks_ssz` and `get_debug_beacon_states_ssz` to pass corresponding timeout durations.
bors
bot
changed the title
## Issue Addressed [Have --checkpoint-sync-url timeout](sigp#3478) ## Proposed Changes I added a parameter for `get_bytes_opt_accept_header<U: IntoUrl>` which accept a timeout duration, and modified the body of `get_beacon_blocks_ssz` and `get_debug_beacon_states_ssz` to pass corresponding timeout durations.
Issue Addressed
Have --checkpoint-sync-url timeout
Proposed Changes
I added a parameter for
get_bytes_opt_accept_header<U: IntoUrl>which accept a timeout duration, and modified the body ofget_beacon_blocks_sszandget_debug_beacon_states_sszto pass corresponding timeout durations.