Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Push naive attestations into op pool #1466

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Push naive attestations into op pool #1466

wants to merge 2 commits into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

  • When producing a block, go and ensure every attestation in the naive aggregation pool is included in the operation pool. This should help us increase the number of useful attestations in a block.
  • Lift the RwLocks inside NaiveAggregationPool up into a single high-level lock. There were race conditions in the existing setup and it was hard to reason about.

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review consensus An issue/PR that touches consensus code, such as state_processing or block verification. labels Aug 5, 2020
@paulhauner paulhauner mentioned this pull request Aug 6, 2020
Closed
AgeManning
AgeManning approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I'm under the impression a few of us have tested this on the public testnet. Given this assumption, I think we're good to go

@AgeManning AgeManning added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 6, 2020
michaelsproul
michaelsproul approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael-approved

@paulhauner
Copy link
Member Author

I'm under the impression a few of us have tested this on the public testnet. Given this assumption, I think we're good to go

Yep, I've been running it on our internal testnet and also on Medalla.

bors r+

bors bot pushed a commit that referenced this pull request Aug 6, 2020
@paulhauner
Push naive attestations into op pool (#1466)
0b287f6 
## Issue Addressed

NA

## Proposed Changes

- When producing a block, go and ensure every attestation in the naive aggregation pool is included in the operation pool. This should help us increase the number of useful attestations in a block.
- Lift the `RwLock`s inside `NaiveAggregationPool` up into a single high-level lock. There were race conditions in the existing setup and it was hard to reason about.

## Additional Info

NA
@bors
Copy link

bors bot commented Aug 6, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Push naive attestations into op pool [Merged by Bors] - Push naive attestations into op pool Aug 6, 2020
@bors bors bot closed this Aug 6, 2020
@michaelsproul michaelsproul deleted the more-attestations branch August 6, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
consensus An issue/PR that touches consensus code, such as state_processing or block verification. ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulhauner @michaelsproul @AgeManning