Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiline output for release notes on CI #3750

Closed
michaelsproul opened this issue Nov 24, 2022 · 1 comment
Closed

Fix multiline output for release notes on CI #3750

michaelsproul opened this issue Nov 24, 2022 · 1 comment
Labels
infra-ci v3.4.0 Minor release following v3.3.0

Comments

@michaelsproul
Copy link
Member

michaelsproul commented Nov 24, 2022 •
edited
Loading

Description

The release CI crashes when outputting the multiline string for the release notes. We should use a "here document" like <<<EOF to escape the mulitline string.

CI crashing: https://github.com/sigp/lighthouse/actions/runs/3537291461

Fix (option 2): https://trstringer.com/github-actions-multiline-strings/

Testing will require running the release flow on a dummy release on someone's fork.

Version

Should be fixed before v3.4.0
@michaelsproul michaelsproul added infra-ci v3.4.0 Minor release following v3.3.0 labels Nov 24, 2022
@michaelsproul michaelsproul mentioned this issue Dec 16, 2022
Closed
bors bot pushed a commit that referenced this issue Dec 20, 2022
@michaelsproul
Various CI fixes (#3813)
cb1eb76 
## Issue Addressed

Closes #3812
Closes #3750
Closes #3705
bors bot pushed a commit that referenced this issue Dec 20, 2022
@michaelsproul
Various CI fixes (#3813)
59a7a47 
## Issue Addressed

Closes #3812
Closes #3750
Closes #3705
macladson pushed a commit to macladson/lighthouse that referenced this issue Jan 5, 2023
@michaelsproul @macladson
Various CI fixes (sigp#3813)
78bd301 
## Issue Addressed

Closes sigp#3812
Closes sigp#3750
Closes sigp#3705
@paulhauner
Copy link
Member

Resolved via #3813

Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@michaelsproul @Woodpile37
Various CI fixes (sigp#3813)
8e6ad3a 
## Issue Addressed

Closes sigp#3812
Closes sigp#3750
Closes sigp#3705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra-ci v3.4.0 Minor release following v3.3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @paulhauner