-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hook for formatting, linting, and sorting #172
base: unstable
Are you sure you want to change the base?
Conversation
I think invoking the appropriate commands in the Makefile would be more appropriate, in order to use the flags specified there. i.e. |
I agree. Are they |
@dknopik should we get it merged like this? |
@diegomrsantos how about the switch to invoking the |
The make targets have an error that causes the script to fail. Additionally, the fmt and lint ones only check and don't apply fixes. |
The make targets work fine on my end, and are also what's used in CI. But I will likely not use this anyway 🤷♂️ |
Proposed Changes
Create a pre-commit file in
.githooks
. You only need to rungit config core.hooksPath .githooks
and the old days of CI failures are over.