Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(push): fixes push notifications not showing (#100) #107

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

btaens
Copy link
Contributor

@btaens btaens commented Jul 24, 2019

📋 Description

Fixes push notifications not showing on any desktops by checking whether target has image_url when retrieving iconChat, avoiding an exception thrown as described in #100.

🗂 Type

  • 🍾 Feature
  • 🚨 Bugfix
  • 📒 Documentation
  • 👷 Internals

🔥 Severity

  • 💎 Non-Breaking Changes
  • 💔 Breaking Changes

🖥 Platforms

  • 🍏 macOS
  • 💾 Windows
  • 🐧 Linux

🛃 Tests

  • My changes have been tested manually.
  • My changes are covered by automated testing methods.

👨‍🎓 Miscellaneous

  • My changes follow the style guide.
  • My changes require updates to the documentation.

@sidneys
Copy link
Owner

sidneys commented Nov 14, 2019

@btaens Thank you, this will be in the next release as well.

@sidneys sidneys closed this Nov 14, 2019
@sidneys sidneys reopened this Nov 14, 2019
@sidneys sidneys merged commit 3b92d4a into sidneys:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants