Updates #6
Merged
Updates #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangping
reviewed
Apr 28, 2023
|
|
||
| ### Motivation | ||
|
|
||
| ICS-101 Interchain Swaps enables chains their own token pricing mechanism and exchange protocol via IBC transactions. Each chain can thus play a role in a fully decentralised exchange network. | ||
|
|
||
| Users might also prefer single asset pools over dual assets pools as it removes the risk of impermanent loss. | ||
| Features include an option to provide liquidity with a single asset instead of a pair, which users might prefer as it removes the risk of impermanent loss. |
liangping
reviewed
Apr 28, 2023
| - Timeout: Swap order need to be confirmed on the counterparty chain. it would be canceled and refund if packets not arrival the counterparty on time. | ||
| - Slippage Tolerance can be a way to protect loss caused by in-consistency. | ||
| - Single side trade: Each Token can only be trade its native chain. in inconsistency state, the backlog swap would sell lower prices than consistency state. which could help to maintain consistency. | ||
| - Timeout: Packets timeout when packet acknowledgements are delayed for extended period of times. This limits the impact of inconsistent pool states on mispriced swap orders. |
There was a problem hiding this comment.
timeout when packet delivery, acknowledgement don't have timeout,
liangping
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates