Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolver with Maven 4 #378

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Dec 22, 2024

@lprimak Lenny, could you check if that helps for your use cases ?

@cstamas
Copy link
Contributor

cstamas commented Dec 22, 2024

This is the missing piece from #375 !
Note: that PR also fixes session creation, as it uses MIMA context (that in Maven4 contains "real" context)

@lprimak
Copy link
Contributor

lprimak commented Dec 22, 2024

I see no effect at all, positive or negative. This could not hurt, but I don't see it helping other than guessing that it could improve performance somewhat.

@lprimak
Copy link
Contributor

lprimak commented Jan 10, 2025

@gnodet please un-draft this

@gnodet gnodet marked this pull request as ready for review January 15, 2025 06:27
@lprimak
Copy link
Contributor

lprimak commented Feb 26, 2025

@petrberan Can you please merge this?
It also applies to Maven 3.

Once this is merged, a release would be appreciated.
Thank you!

@petrberan
Copy link
Member

Can you rebase this so the CI can kick off again @gnodet ?

@lprimak
Copy link
Contributor

lprimak commented Feb 28, 2025

@petrberan I think you need to kick off CI manually since @gnodet is a first-time contributor... but I maybe wrong

@petrberan
Copy link
Member

Don't have the option to sadly @lprimak . Github is able to rerun CI for only 30 days old PRs (though it's set to 90 days, not sure why it doesn't honor the settings). Sadly, this needs a rebase

@petrberan petrberan merged commit 58c3a52 into shrinkwrap:master Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants