Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHRINKRES-354] update to keep track of changes in maven 4-rc-1 #369

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Dec 8, 2024

Maven team has changed how project-local pom is organized slightly.
-consumer.pom files have been renamed to just .pom
This PR fixes problems associated with that change
Added org.jboss.shrinkwrap.resolver.maven.ignoreDecryptionProblems system property
to ignore security issues since maven 4 completely changed the format of encrypted passwords

added org.jboss.shrinkwrap.resolver.maven.ignoreDecryptionProblems system property to ignore maven 4 decryption issues
@lprimak lprimak force-pushed the update-to-maven-4-rc1-1 branch from 3930b8e to 85d6e39 Compare December 9, 2024 04:59
@lprimak lprimak marked this pull request as ready for review December 9, 2024 04:59
@lprimak lprimak changed the title chore: update to keep track of maven changes in 4-rc-1 [SHRINKRES-354] chore: update to keep track of maven changes in 4-rc-1 Dec 9, 2024
@lprimak lprimak changed the title [SHRINKRES-354] chore: update to keep track of maven changes in 4-rc-1 [SHRINKRES-354] chore: update to keep track of changes in maven 4-rc-1 Dec 9, 2024
@lprimak lprimak changed the title [SHRINKRES-354] chore: update to keep track of changes in maven 4-rc-1 [SHRINKRES-354] update to keep track of changes in maven 4-rc-1 Dec 9, 2024
Copy link
Member

@petrberan petrberan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petrberan
Copy link
Member

Thanks for keeping eye on the changes @lprimak ! I'd like to release another version before Christmas, can't do that since we have test failing (http://archive.apache.org is off). Is there some changes you'd like to get in or would those wait for next year?

@lprimak
Copy link
Contributor Author

lprimak commented Dec 10, 2024

This PR is everything I would like to get into the new release. I would like to get this in before the holidays.
Thank you!

@petrberan petrberan merged commit 440000e into shrinkwrap:master Dec 12, 2024
3 checks passed
@petrberan
Copy link
Member

New version is out and should be available in couple of hours @lprimak . Won't probably have a look at the project until next year as I have PTO until EOY. As a matter of fact, I'm on my PTO right now :)

See you next year!

@lprimak lprimak deleted the update-to-maven-4-rc1-1 branch December 12, 2024 13:57
@lprimak
Copy link
Contributor Author

lprimak commented Dec 12, 2024

Relax and enjoy. I’ve been on non-paid PTO since 2020 :)

@cstamas
Copy link
Contributor

cstamas commented Dec 21, 2024

This PR, as #341 is wrong, for context see https://issues.apache.org/jira/browse/MNG-8464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants