Skip to content
This repository was archived by the owner on Oct 17, 2020. It is now read-only.

Change Toggle SCSS to utilize CSS modules #962

Merged
merged 3 commits into from
Jul 18, 2020
Merged

Conversation

Coteh
Copy link
Collaborator

@Coteh Coteh commented Jul 17, 2020

Bare minimum to fix #960 and make it renderable in Storybook.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #962 into master will decrease coverage by 29.58%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #962       +/-   ##
===========================================
- Coverage   52.69%   23.11%   -29.59%     
===========================================
  Files         139       76       -63     
  Lines        3418     1337     -2081     
  Branches      167      167               
===========================================
- Hits         1801      309     -1492     
+ Misses       1557     1028      -529     
+ Partials       60        0       -60     
Flag Coverage Δ
#golang ?
#typescript 23.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/component/ui/Toggle.tsx 100.00% <ø> (ø)
backend/app/adapter/sqldb/googlesso.go
backend/app/adapter/gqlapi/resolver/authquery.go
backend/app/usecase/shortlink/metatag.go
backend/app/adapter/sqldb/userrole.go
backend/app/adapter/gqlapi/resolver/changelog.go
backend/app/adapter/gqlapi/resolver/resolver.go
backend/app/adapter/sqldb/featuretoggle.go
backend/app/usecase/sso/identityprovider_fake.go
backend/app/usecase/sso/sso.go
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00df27f...f5d83b1. Read the comment docs.

@magicoder10 magicoder10 merged commit 239bb4e into master Jul 18, 2020
@magicoder10 magicoder10 deleted the toggle-scss-module branch July 18, 2020 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Toggle should use CSS module
2 participants