-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go version in module #1804
base: master
Are you sure you want to change the base?
Conversation
7c8a2dd
to
84c9b6e
Compare
Thank you for the suggestion! However, gopsutil is a library that supports a wide range of platforms. Not all platforms provide the latest version of Go in their package managers, and some users might not be able to upgrade their Go version. gopsutil depends on Of course, if there’s a need to use new language features in Go, I’m not against it. However, I think we should discuss whether it’s truly necessary at that time. |
Would you consider at least 1.19 ? That would then allow to extend golangci-lint matrix for loong64 |
github.com/google/go-cmp require go1.21 and there are no workflows that are still using go1.19 |
af79113
to
36b7f45
Compare
I just noticed golang/go#69095. This proposal suggests automatically updating the In the discussion, there are comments suggesting that the required version should be set to the minimum, but it seems that people like rsc believe it's important to encourage the use of the latest version. Personally, I also agree with the idea of keeping the version at the minimum. However, the overall direction of Go team seems to be to promote the use of the latest version. Therefore, I've changed my mind and now think it might be better to change |
Alright, that ready to Go :) ! Golangci-lint timeout it extended because of Windows exeeding it. |
ff4a1cb
to
4248431
Compare
Thank you for the update. However, when I looked at the diff, I wondered, "Why is the It doesn't seems to be resolved yet, so how about removing the |
01d6f63
to
194d27d
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
Description
Go 1.24.0 has been released on since 11 February 2025
This updates Go version from 1.18 to 1.23
Notice that loong64 arch is only available since Go1.19 so it's surprising to see that gopsutil supports it (at least partially) with a Go1.18 module.