Handle invalid numeric inputs for props to avoid crash #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roni-castro-shipt
force-pushed
the
support/handle-invalid-numeric-inputs
branch
from
70987ad to
6dbc63e
Compare
roni-castro-shipt
force-pushed
the
support/handle-invalid-numeric-inputs
branch
from
6dbc63e to
e1c5b80
Compare
roni-castro-shipt
force-pushed
the
support/handle-invalid-numeric-inputs
branch
from
e1c5b80 to
13927ac
Compare
Ensure invalid segments are returned in their original order. Default values remain unchanged.
This reverts commit 6fa53ae.
roni-castro-shipt
force-pushed
the
support/handle-invalid-numeric-inputs
branch
from
b38429b to
057a3c3
Compare
roni-castro-shipt
force-pushed
the
support/handle-invalid-numeric-inputs
branch
from
057a3c3 to
3c68380
Compare
This reverts commit 392e81b.
roni-castro-shipt
force-pushed
the
support/handle-invalid-numeric-inputs
branch
from
0c0d608 to
6143470
Compare
roni-castro-shipt
changed the base branch from
development
to
support/Roni/CU-86b39mr3a/handle-invalid-numeric-inputs
roni-castro-shipt
merged commit 9a2eb96
into
shipt:support/Roni/CU-86b39mr3a/handle-invalid-numeric-inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - It depends on another PR code
Description
Currently, if NaN is passed for numeric props, the app crashes.
Solution
Ensure that all numeric properties are parsed before use. If the parsed value results in NaN, revert to the default value for that property and issue a warning that an invalid value was provided and its value was changed to the default one. If the value is valid, maintain the existing behavior and don't show warning
Screenshots
Android
before_android_fillValue_NaN.mp4
after_android_fillValue_NaN.mp4
iOS
before_android_fillValue_NaN.mp4
after_ios_fillValue_NaN.mp4
No warnings if props if some props are not passed and are numeric
Warnings shown only once
warnings_for_invalid_props_shown_once.mp4