Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoVim man pager cannot handle colours correctly after enabling vim-polyglot #576

Closed
Frederick888 opened this issue Oct 7, 2020 · 5 comments

Comments

@Frederick888
Copy link

Frederick888 commented Oct 7, 2020

Does this bug happen when you install plugin without vim-polyglot?
No.

Describe the bug:
With vim-polyglot enabled, nvim manpager cannot handle colours correctly. See screenshot:
Screen Shot 2020-10-07 at 6 17 01 pm
And nvim warns that file's been modified when :q.

If I open nvim first then :Man man, the colours are ok but it somehow still modifies the [No Name] buffer and I can see a warning when :qa.

To Reproduce:

  1. Using NeoVim v0.4.4, macOS or Linux
  2. export MANPAGER='nvim +Man!'
  3. Use the init.vim below
  4. man man
set runtimepath^=~/.vim runtimepath+=~/.vim/after
let &packpath = &runtimepath

call plug#begin()
Plug 'sheerun/vim-polyglot'
call plug#end()
@sheerun
Copy link
Owner

sheerun commented Oct 7, 2020

I can't reproduce colors issue, but I can reproduce warning when trying to exit

@sheerun sheerun closed this as completed in 619a7a8 Oct 7, 2020
@Frederick888
Copy link
Author

@sheerun After updating vim-polyglot both my issues were fixed. Thank you!

@vokar
Copy link

vokar commented Oct 17, 2020

@sheerun, I just pulled the last changes and now have the same problem. Looking through the commit history, I found that you returned the man plugin in af3ebda, so that's the reason.

I have NVIM v0.4.4 too.

@sheerun
Copy link
Owner

sheerun commented Oct 18, 2020

Man, I was supposed to add only filetypes detection, thank you!

@vokar
Copy link

vokar commented Oct 18, 2020

No problem. Thank you for the quick reaction and for adding a regression test 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants