implement maximum priority #114
Conversation
homu/main.py
Outdated
| except ValueError: | ||
| pass | ||
|
|
||
| if pvalue > global_cfg['max_priority']: |
There was a problem hiding this comment.
I think this will break if we write p=foo now:
>>> try:
... p = int("foo")
... except ValueError:
... pass
...
>>> print(p)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NameError: name 'p' is not defined
There was a problem hiding this comment.
Updated to continue there instead. I assume that we do not want to save a non-integer value like "foo" in the state object, as it might pop out and break things when it's read elsewhere.
This is required to do servo#111 the easy way.
|
@jdm I think we're good to merge if you'd like to r+. I was reminded in the other PR that I was wrong about landing order -- we'll need to pin the merge commit in the saltfs changeset for the new Homu version to get deployed. |
|
@jdm Do you have any other comments? I think we're ready to go with this from my point of view! |
|
@bors-servo: r+ |
|
📌 Commit 607c5f5 has been approved by |
implement maximum priority If this deploys before servo/saltfs#660 lands, it might break. Tagging blocked on external till saltfs 660 lands. This is required to do #111 the easy way. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/114) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
If this deploys before servo/saltfs#660 lands, it might break. Tagging blocked on external till saltfs 660 lands.
This is required to do #111 the easy way.
This change is